Upgrade: update eslint dependency to ^3.0.0 (refs #15)

angelozerr / tern-eslint

Tern Plugin to validate JS files with ESLint

https://github.com/eslint/eslint

MIT License

10 stars 6 forks source link

Closed nostalic closed 7 years ago

nostalic commented 7 years ago

nostalic commented 7 years ago

Hi @angelozerr eslint v3.x dropped support for node < 4 and updated their travis config accordingly - while tern 0.21 is still supporting node_js 0.10.

Are you ok with updating the travis config to match the one from eslint 3.x for this plugin?

angelozerr commented 7 years ago

Are you ok with updating the travis config to match the one from eslint 3.x for this plugin?

Yes sure.

nostalic commented 7 years ago

Done! Any other changes / check before this can be merged? Should I update the defaultConfig to match changes in https://eslint.org/docs/user-guide/migrating-to-3.0.0#changes-to-eslintrecommended as well?

nostalic commented 7 years ago

@angelozerr I updated the defaultConfig to match eslint:recommended - could you review the changes and see if the pull request can be merged?

I am planning on updating the plugin to eslint v4.5 next - do you see any additional steps for the update in addition to the one listed below?

[ ] Update eslint dependency in package.json
[ ] Validate tests and update travis config to match eslint's
[ ] Update browserified eslint in demos
[ ] Update recommended setting in defaultConfig and update tests as appropriate

angelozerr commented 7 years ago

Thanks @nostalic !