angelozerr / tern.jsduck

Tern Plugin for ExtJS, CKEditor
MIT License
9 stars 3 forks source link

Fix extjs autocompletion #3

Closed fflorent closed 8 years ago

fflorent commented 8 years ago

A series of changes including :

Don't hesitate to review and tell me what you would like to change.

Cheers! Florent

[1] If that seems to be specific to ExtJS, the doc mentions that other framework might use that feature too. Also I managed to check the name of the constructor parameter to ensure it's named config so it's secure.

angelozerr commented 8 years ago

Thanks @fflorent for your work! IMHO I think It should be very cool if with have tests like https://github.com/angelozerr/tern-tabris/tree/master/test

Do you think it's possible for you to create a new PR? Do you want to become contributor of tern.jsduck?

fflorent commented 8 years ago

Do you think it's possible for you to create a new PR? Do you want to become contributor of tern.jsduck?

Sure for both! I'll probably work on that on tuesday and wednesday.

Florent

angelozerr commented 8 years ago

Sure for both! I'll probably work on that on tuesday and wednesday.

Cool! I add you as collaborator. I'm not very active because I'm busy with tern.java (integration of ternjs inside Eclipse). I will integrate yoru work inside tern.java