Closed fflorent closed 8 years ago
Great work @fflorent !
Using !proto in !define objects introduces a weird regression I can't explain.
Could you give me a sample?
Could you give me a sample?
Here for example:
Same if you use new Ext.grid.Panel({sto<tab>})
syntax.
The Ext_some_Class_cfg
type was introduced in PR #3 to allow auto-completion of config objects.
Florent
6 (part 1) reduce the size of the plugin files taking advantages of inhenritance
Ext.button.Button.handler
was :fn()|string
; now :fn(button: +Ext.button.Button, e: +Ext.event.Event)|string
)5 [ExtJS] Make completion work on class definition with inheritance
Some bugs:
button
argument ofExt.button.Button.handler()
. I noticed the type in the hint of the function for this argument was "Ext.button.Button" despite what is specified in the definition (that is "+Ext.button.Button").?
instead of+Ext.event.Event
!proto
in!define
objects introduces a weird regression I can't explain. For example, the type ofExt.grid.Panel.prototype.store
isExt_panel_Table_cfg.store
(Ext_grid_Panel_cfg
extendsExt_panel_Table_cfg
). Wonder if that's a tern issue. Thoughts?We may fix these bugs before merging or merge immediately if you think those are acceptable.
Florent