angelozerr / tslint-language-service

TypeScript 2.2.1 plugin for tslint
MIT License
188 stars 22 forks source link

Unmet peerdep warning #23

Closed mhartington closed 7 years ago

mhartington commented 7 years ago

Hi there! I was attempting to use this plugin with TS 2.3.0 but got a UNMET PEER DEPENDENCY error.

├── tslint-language-service@0.9.2
└── UNMET PEER DEPENDENCY typescript@2.3.0

npm WARN tslint-language-service@0.9.2 requires a peer of typescript@2.2.x but none was installed.

Since TS 2.3.0 is out now, would it be possible to bump the peerDep for typescript?

https://github.com/angelozerr/tslint-language-service/blob/master/package.json#L26

Things still install correctly, but it would be nice to not get a warning, which could scare people off.

Either way, this plugin is great, and works perfectly with my typescript service for neovim. Thanks!

angelozerr commented 7 years ago

Since TS 2.3.0 is out now, would it be possible to bump the peerDep for typescript?

We are fixing this issue in https://github.com/angelozerr/tslint-language-service/pull/24

Either way, this plugin is great, and works perfectly with my typescript service for neovim. Thanks!

Glad this plugin is helpful for you!

mhartington commented 7 years ago

Ah! I should have look harder 😄

I'll close this since there's a PR.

angelozerr commented 7 years ago

@mhartington please reinstall 0.9.3, it should fix your issue.

mhartington commented 7 years ago

Looks good! Thanks!