angelozerr / tslint-language-service

TypeScript 2.2.1 plugin for tslint
MIT License
188 stars 22 forks source link

vscode fixes and tips #28

Closed abierbaum closed 7 years ago

abierbaum commented 7 years ago

When using the vscode tslint plugin, I am presented with a "lightbulb" icon of tips for fixing the lint issues or disabling them. When running without the tslint plugin and just the language service I do not see a tip icon. Is this something that can be added or does it require a plugin to vscode to work?

amatiasq commented 7 years ago

Same thing here, after restarting vscode multiple times it didn't work. Now after 12 hours I saw the lightbulb icon on a linting issue but after I use a single quickfix I have to close and open the file again in order to see the lightbulb again :\

I guess it's related that the language service doesn't update when I type on the file.

angelozerr commented 7 years ago

@egamma have you an idea about this issue?

egamma commented 7 years ago

@angelozerr this looks like issue https://github.com/palantir/tslint/issues/2649

My fix from this PR https://github.com/angelozerr/tslint-language-service/pull/20 is not in the published 0.9.3 module. I suspect the TypeScript code was not compiled before the node module was published and an older version got published.

angelozerr commented 7 years ago

My fix from this PR #20 is not in the published 0.9.3 module.

Oooops, sorry -( I have created a new release with 0.9.4. Sorry @egamma to have loosing your time.

@abierbaum @amatiasq could you retry with 0.9.4 please.

abierbaum commented 7 years ago

@angelozerr @egamma Works perfect with 0.9.4. Thanks so much!!!

egamma commented 7 years ago

@abierbaum great, pls remember this restriction from the README

Notice due to an issue in the implementation of the no-unused-variable rule (issue15344]), this rule will be disabled by the plugin. You can use the typescript compiler options noUnusedLocals and noUnusedParameters instead.

OliverJAsh commented 7 years ago

Hi, I am expecting to see a quick fix for this error but I don't see any. Using 0.9.4:

image

OliverJAsh commented 7 years ago

My bad, quick fix only appears when the cursor is inside the error. Ignore the above.

amatiasq commented 7 years ago

@angelozerr Updated from version 0.9.3 to 0.9.6 Works perfectly now! Thanks guys!