search

angelozerr / tslint-language-service

TypeScript 2.2.1 plugin for tslint
MIT License
188 stars 22 forks source link

configFile is broken #55

Closed krzkaczor closed 6 years ago

krzkaczor commented 6 years ago

First of all, I want to say thank you for this awesome plugin.

I noticed that configFile is broken for me because it assumes relative path to CWD which often is not a project root (you can ran vsc from terminal on different project but all windows share CWD). You can't really use absolute paths either because they would be different for every machine.

I have already patched version running locally (man, debugging ts language services is crazy :D) it always uses a relative path from project root. PR incoming in a sec.

andyrooger commented 6 years ago

Perfect timing. Thanks @krzkaczor.

@angelozerr Do you know how long this would take to make it into npm?

angelozerr commented 6 years ago

@andyrooger I will try to do that this week.

angelozerr commented 6 years ago

@andyrooger I have published 0.9.8. Thanks @krzkaczor !