angkl0 / pe

0 stars 0 forks source link

Able to add a person with semantically same name as a person in members list #2

Open angkl0 opened 1 year ago

angkl0 commented 1 year ago

Screenshot 2022-11-11 at 4.20.38 PM.png

To reproduce: Type add n/roy balakrishnan p/123 e/roy@me.com a/213

Expected: Error message stating the restriction of adding a person with the same name as an existing person in the members list

Actual: Person is added.

nus-se-script commented 1 year ago

Team's Response

Adding people with the same name is allowed in our application. This is the intended behaviour. Although unlikely, it is entirely possible for two people to have the exact same name. Only the email is required to be unique in our application.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Firstly, the team did not provide any justification as to why it has decided to classify this issue as NotInScope.

Secondly, given that name is a contact's most prominent feature, even if adding people with same name is intended, it is still better to warn in such cases as per the module website to alert the user to prevent cases such as users mistakenly adding a duplicate contact with different emails since it is common for a person to have multiple emails.

In light of the team's clarification that only email is required to be unique for a contact instead of name as stated in the UG, I propose to revise the severity to severity.Low and bug type to FeatureFlaw.