search

angr / angr-management

The official angr GUI.
BSD 2-Clause "Simplified" License
864 stars 108 forks source link

Update to BinSync version 4 #1158

Closed mahaloz closed 4 months ago

twizmwazin commented 4 months ago

@mahaloz Can you test using one one of the pyinstaller artifacts produced by the bundle job? If everything works there as expected then this lgtm.

mahaloz commented 4 months ago

@twizmwazin when I use the PyInstaller version I get an import error for things that clearly exist:

WARNING | 12:15:51 | angrmanagement.plugins.plugin_manager | Exception occurred during plugin loading: No module named 'binsync.interface_overrides.angr'
NoneType: None

Here is the file: https://github.com/binsync/binsync/blob/main/binsync/interface_overrides/angr.py

mahaloz commented 4 months ago

Do I need to somehow specify them with:

__all__ = ["angr"]

Or something?

twizmwazin commented 4 months ago

No module means that pyinstaller didn't find it when searching the import graph. Try pushing a commit adding the import to this list and seeing if that fixes it

mahaloz commented 4 months ago

@twizmwazin we are good to go