Closed ghost closed 1 year ago
This totally slipped under my radar, thanks!
Looks like this change breaks the panda target which creates creating MemoryMap objects here without setting a value for permission.
Are these permissions actually used somewhere? if so we can expand the panda target to specify this information. Otherwise maybe we could just allow perms to be None here?
EDIT: I think I'm getting a better understanding of this now - the change to the MemoryMap object was required, so we can't just leave it as None
. I think Zak's PR fixes this for the PANDA target.
In the new version of
gdb-multiarch (13.1)
,self.target.protocols.memory.get_mappings()
returns an additional attributePerms
, which causes the currentavatar_gdb.get_mappings()
function to fail to obtainmap_name
correctly.old:
new:
So I added some code in
avatar_gdb.get_mappings()
function to getPerms
andmap_name
correctly and modifiedclass MemoryMap
accordingly.old:
new: