angr / angr-targets

This repository contains the currently implemented angr concrete targets.
32 stars 9 forks source link

no such option --process-dependency-links #7

Closed bannsec closed 3 years ago

bannsec commented 4 years ago

As of pip version 19, there is no longer the option --process-dependency-links.

twizmwazin commented 4 years ago

This is default behavior now, correct? So the proper solution would be to stop using the flag, and remove it from the readme.

bannsec commented 4 years ago

I had just tried installing it and basically it installs without installing the avatar2 requirement.

On Tue, May 12, 2020, 3:56 PM Kevin Phoenix notifications@github.com wrote:

This is default behavior now, correct? So the proper solution would be to stop using the flag, and remove it from the readme.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angr/angr-targets/issues/7#issuecomment-627559558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2HPYGR7TSDA4PH2DCQXTDRRGSXJANCNFSM4M63GUVA .

twizmwazin commented 4 years ago

@bannsec What is your sys.platform? https://github.com/angr/angr-targets/blob/master/setup.py#L10

Also should note, this is not how platform specific dependencies should be handled, setuptools has a way to handle them.

bannsec commented 4 years ago

Ah, well that would explain that. Installed on windows.

On Tue, May 12, 2020, 4:05 PM Kevin Phoenix notifications@github.com wrote:

@bannsec https://github.com/bannsec What is your sys.platform? https://github.com/angr/angr-targets/blob/master/setup.py#L10

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angr/angr-targets/issues/7#issuecomment-627564130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2HPYEPABODFNZRB7QBFELRRGTXHANCNFSM4M63GUVA .

stevenskevin commented 3 years ago

This isn't fixed -- the readme still suggests an installation command that no longer works. Could this issue be reopened?

ltfish commented 3 years ago

@twizmwazin ping

twizmwazin commented 3 years ago

@stevenskevin You should be able to install this using python setup.py develop or pip install -e .

stevenskevin commented 3 years ago

I was able to install this by temporarily downgrading pip to 18.1. I'd just like for the readme to be updated so that it doesn't recommend a broken command, is all.