angr / angr-z3

The Z3 Theorem Prover - repository for staging python distributions
Other
55 stars 15 forks source link

fix osx library extension .so to .dylib #1

Closed cao closed 9 years ago

cao commented 9 years ago

On OS X, libz3.so will not be build. Instead .dylib will be build. Copy the correct file.

zardus commented 9 years ago

Thanks!

musically-ut commented 9 years ago

Won't a similar test be needed for Windows to use the .dll as well?

cao commented 9 years ago

Yes a similar check is needed for Windows, I don't have a Windows installation where I can test it though, hence I didn't add it.

cao commented 9 years ago

To add: The change might be as trivial as adding a

elif sys.platform == 'windows':
    library_file = "libz3.dll"

but without actually testing it I don't feel comfortable to make a pull request. If you have a Windows installation and tested it, please create a pull request!