search

angr / angr-z3

The Z3 Theorem Prover - repository for staging python distributions
Other
56 stars 15 forks source link

Fix for [[clang::fallthrough]] #6

Closed pietrodn closed 7 years ago

pietrodn commented 7 years ago

This fixes the [[clang::fallthrough]] issue and ensures a successful build of angr-z3 on macOS.

This is the same fix introduced upstream in Z3: https://github.com/Z3Prover/z3/commit/f03f471f025adaed6f82d73b7e19fc8693bbec4f

zardus commented 7 years ago

angr-z3 is a for-convenience fork of the actual Z3 repo (https://github.com/Z3Prover/z3). Please send this PR to them.

Thanks!

pietrodn commented 7 years ago

They already fixed it upstream. https://github.com/Z3Prover/z3/commit/f03f471f025adaed6f82d73b7e19fc8693bbec4f

zardus commented 7 years ago

Ah, cool. Then I guess @rhelmot will pull it in for the next z3 release. Thanks for pointing it out!

rhelmot commented 7 years ago

Luckily for you, I am procrastinating hardcore on an essay due in 7 hours, so angr-z3 has been rebased on latest upstream, and a source release has been made. Linux wheels are in the process of being built :)

pietrodn commented 7 years ago

Currently, this is the only problem preventing a "clean" install (with just "pip install angr") of angr on macOS.

rhelmot commented 7 years ago

As of right now, it should be fixed for macOS.

pietrodn commented 7 years ago

Tried right now, it works fine. Thank you! :)