search

angr / archr

Target-centric program analysis.
BSD 2-Clause "Simplified" License
72 stars 20 forks source link

Fix file leak in QEMU tracer #138

Closed dnivra closed 1 year ago

dnivra commented 1 year ago

Currently, mktemp is used to get name of a temporary file to which the QEMU output file from taregt is copied to. However, this file is never cleaned up and mktemp seems to be deprecated. This PR replaces mktemp with a NamedTemporaryFile that is cleaned up at the end. All CI runners seem to have failing test cases on master so I'm guessing I didn't break anything with this change.

github-actions[bot] commented 1 year ago

Test Results

  20 files  +10    20 suites  +10   25m 37s :stopwatch: + 10m 6s 103 tests +21    76 :heavy_check_mark: +21    26 :zzz: ±0  1 :x: +1  460 runs  +21  330 :heavy_check_mark: +21  129 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit abc6adaa. ± Comparison against base commit fafe677a.

:recycle: This comment has been updated with latest results.

Kyle-Kyle commented 1 year ago

can you rebase the PR and run the CI again? I'll try to fix the CI soon-ish.

Kyle-Kyle commented 1 year ago

can you please rebase the PR? archr CI is finally fixed after so many years

Kyle-Kyle commented 1 year ago

thanks!