search

angr / claripy

An abstraction layer for constraint solvers.
BSD 2-Clause "Simplified" License
284 stars 93 forks source link

Only edit signal handling in main thread #313

Closed zwimer closed 1 year ago

zwimer commented 1 year ago

@rhelmot Correct me if I'm wrong, but old_handler should only ever be used in the signal handler after defined, which should only be invoked in the main thread.

Edit: Oh, I see, you mean exclusively in the a non-main thread. I can edit this.

rhelmot commented 1 year ago

Oops! Yes, that is correct.

zwimer commented 1 year ago

I can revert the last commit. I believe it might just add a few cycles to import via the syscall; but it doesn't harm anything. Lmk which you prefer

rhelmot commented 1 year ago

I don't see how either version will cause problems now, but I approve regardless.

github-actions[bot] commented 1 year ago

Unit Test Results

     94 files  +     84       94 suites  +84   1h 0m 33s :stopwatch: + 1h 0m 3s 1 398 tests +1 094  1 308 :heavy_check_mark: +1 064  90 :zzz: +30  0 :x: ±0  1 404 runs  +1 100  1 314 :heavy_check_mark: +1 070  90 :zzz: +30  0 :x: ±0 

Results for commit 5b4c8016. ± Comparison against base commit b5c4baa1.

:recycle: This comment has been updated with latest results.