search

angr / patcherex

Shellphish's automated patching engine, originally created for the Cyber Grand Challenge.
BSD 2-Clause "Simplified" License
251 stars 45 forks source link

Update progress bar to rich #48

Closed Cl4sm closed 1 year ago

Cl4sm commented 1 year ago

Bringing the progressbar into the modern era.

angr pr https://github.com/angr/angr/pull/3885 angr-doc pr https://github.com/angr/angr-doc/pull/462

github-actions[bot] commented 1 year ago

Test Results

184 tests  ±0   171 :heavy_check_mark: ±0   12m 3s :stopwatch: -12s   10 suites ±0     13 :zzz: ±0    10 files   ±0       0 :x: ±0 

Results for commit f51c6eb0. ± Comparison against base commit f888f5e0.

:recycle: This comment has been updated with latest results.

Cl4sm commented 1 year ago

@twizmwazin Thoughts on this? I don't quite like adding progressbar as a dependency when its only use is for a single test-case

twizmwazin commented 1 year ago

If it's just a single test case I'd vote to remove it

Cl4sm commented 1 year ago

Going to remove the dependency entirely.