Test `test_techniques.test_indirectcfi` fails frequently in CI

angr / patcherex

Shellphish's automated patching engine, originally created for the Cyber Grand Challenge.

BSD 2-Clause "Simplified" License

248 stars 45 forks source link

Test `test_techniques.test_indirectcfi` fails frequently in CI #54

Open twizmwazin opened 2 months ago

twizmwazin commented 2 months ago

Description

This test fails frequently in CI. The immediate cause is a timeout from Z3. This should be investigated and fixed if possible, or the test should be rewritten to avoid this issue.

Steps to reproduce the bug

It is difficult to do so as the failure is inconsistent and only usually appears on low-performance systems. Most developers looking at this will likely be using a device too fast to reliably reproduce it.

Environment

No response

Additional context

No response

twizmwazin commented 2 months ago

Echoing @rhelmot in #55 "I'm fine with this diff, but I would like to register the concern that the problem isn't with z3, but rather that patcherex is generating unsolvable constraints. Just so that anyone who sees this in the future doesn't think there was consensus that this was a good fix."