search

angr / pyvex

Python bindings for Valgrind's VEX IR.
BSD 2-Clause "Simplified" License
343 stars 116 forks source link

Submodule can't be cloned: not our ref #396

Closed waarmond closed 6 months ago

waarmond commented 6 months ago

Description

git upload-pack: not our ref 8f48c00eadbb31d379b829c01792a9c4a21636d4
upload-pack: not our ref 8f48c00eadbb31d379b829c01792a9c4a21636d4

Steps to reproduce the bug

${srcdir} stands for the Arch (PKGBUILD) srcdir

  git submodule init
  git config submodule."vex".url "${srcdir}/vex"
  git -c protocol.file.allow=always submodule update --recursive

python -m build --wheel --no-isolation

Environment

Python 3.10, Linux

Additional context

No response

rhelmot commented 6 months ago

It looks like this commit used to exist but got force pushed over and garbage collected. @twizmwazin do you know what happened? I think a3f558b7 should be equivalent, as I still have 8f48c00 on my local machine and git diff says they're the same.

waarmond commented 6 months ago

Clicking the https://github.com/angr/vex/tree/8f48c00eadbb31d379b829c01792a9c4a21636d4 links lets Github display This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

twizmwazin commented 6 months ago

What seems to have happened is I updated the submodule with the commit I had checked out at the time and made two PRs. Here is the vex one where that commit originated. When I merged it on github, github changed some metadata which caused the commit on master to be distinct and have a different hash. I'll update the pyvex submodule to correctly reflect the github master commit.