search

angr / rex

Shellphish's automated exploitation engine, originally created for the Cyber Grand Challenge.
BSD 2-Clause "Simplified" License
634 stars 102 forks source link

`test_rr_broken.py` is breaking all test cases #48

Closed adamdoupe closed 5 years ago

adamdoupe commented 5 years ago

The test cases don't pass (in part) because of the newly added test_rr_broken.py.

The major problem is that this test case hangs and no others are executed (my guess is that it's because rr is not installed on the travis environment, as I can replicate this same behavior on my machine).

https://travis-ci.org/shellphish/rex/builds/521542046?utm_source=github_status&utm_medium=notification

adamdoupe commented 5 years ago

ok, all the test cases are running now (that old link was on a branch where I didn't merge latest),

but the rr test cases are still failing, I think the docker image needs to get built (we can look to the archr tests for that): https://travis-ci.org/shellphish/rex/jobs/521900930#L1040

ltfish commented 5 years ago

If it's broken, it should be named broken_xxx.py so it will be not executed on the CI.

adamdoupe commented 5 years ago

I agree @ltfish , but the broken part of the name comes from our hackathon testing time, so I don't think that's what was intended with the name.

Lukas-Dresel commented 5 years ago

@adamdoupe That was intended, but I thought it was if _broken is in the name :P However, that testcase is no longer needed. I'll remove it.

Lukas-Dresel commented 5 years ago

wait, where is it? I actually already removed it

rhelmot commented 5 years ago

The logic is that anything with test_ is picked up. It's a white list, not a blacklist. Now you know!

On Thu, Apr 18, 2019 at 1:58 PM Lukas Dresel notifications@github.com wrote:

@adamdoupe https://github.com/adamdoupe That was intended, but I thought it was if _broken is in the name :P However, that testcase is no longer needed. I'll remove it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shellphish/rex/issues/48#issuecomment-484687600, or mute the thread https://github.com/notifications/unsubscribe-auth/AATCB5JABF5NHISTLIE725LPRDOHVANCNFSM4HHACNZA .

Lukas-Dresel commented 5 years ago

should be fixed now hopefully