Fixed a typo in the armg_calculate_flag_c helper function

angr / simuvex

[DEPRECATED] A symbolic execution engine for the VEX IR

BSD 2-Clause "Simplified" License

79 stars 57 forks source link

Fixed a typo in the armg_calculate_flag_c helper function #58

Closed iamahuman closed 7 years ago

iamahuman commented 7 years ago

This one might have been somewhat hard to find, since this is usually triggered only when doing things like doing 64-bit integer addition / subtraction with a pair of add / adc or sub / sbc instructions. You may compare this with https://github.com/angr/vex/blob/master/priv/guest_x86_defs.h.

ltfish commented 7 years ago

This is a legit fix! Thank you!

We will get to it once our internal development branch is merged to master.

ltfish commented 7 years ago

@iamahuman Obviously we made quite a lot of changes, and simuvex/vex/ccall.py is moved to simuvex/engines/vex/ccall.py. Can you please rebase your changes and make a new push, so we can merge in this PR? Sorry about that.

iamahuman commented 7 years ago

@ltfish No worries. Here you go ;)

zardus commented 7 years ago

The failing testcase in this one is a known issue. Merging this in!