search

angr / tracer

Utilities for generating dynamic traces
BSD 2-Clause "Simplified" License
88 stars 28 forks source link

Rex needs this #46

Closed tyb0807 closed 6 years ago

tyb0807 commented 6 years ago

@rhelmot @salls please review this. Thanks!

zardus commented 6 years ago

Wouldn't this get wiped in the tracer merge anyways?

On Oct 6, 2017 5:27 PM, "tyb0807" notifications@github.com wrote:

@rhelmot https://github.com/rhelmot @salls https://github.com/salls please review this. Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/angr/tracer/pull/46 Commit Summary

  • Rex needs this

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/angr/tracer/pull/46, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSzl-ARVlKBrguby5rndWasbd05IePmks5spjizgaJpZM4PwkEr .

tyb0807 commented 6 years ago

Yes, but if you want to fix rex first (that's what I'm doing), you'll need to fix the old tracer with this.

zardus commented 6 years ago

So to confirm: you want to merge this, and rebase your tracer-merge PR on top of it?

tyb0807 commented 6 years ago

Yup, otherwise you cannot verify rex fixes can you?

zardus commented 6 years ago

From my personal perspective, fixing rex with the current state is useful only to help make sure it works after the tracer merge. If you tell me it works, then we end up merging the tracer into angr and it still works, then that's good enough for me :-)

That being said, I'm down to merge this. @salls, can you sign off? I don't know this part enough to judge.

tyb0807 commented 6 years ago

I see, so please feel free to close this. The most important thing now is fixing rex anyways, I need your help on that :(

salls commented 6 years ago

Looks good to me