angr / vex

A patched version of VEX to work with PyVEX.
GNU General Public License v2.0
104 stars 44 forks source link

Added translation for instruction LDRSW (literal). #12

Closed phros closed 6 years ago

phros commented 6 years ago

The operand is interpreted relatively to the current instruction pointer/program counter. See ARMv8-A Architecture Reference Manual (C6.6.95)

zardus commented 6 years ago

Have you submitted this to valgrind? Maintaining an actual fork of VEX is something we'd prefer to avoid, so if it's only present in angr/vex, and we rebase on a later version of VEX from valgrind, and there are conflicts, it's very likely that this would get dropped...

phros commented 6 years ago

No I didn't do it so far. I will give it a try to reach the valgrind maintainers.

AndyXan commented 6 years ago

FYI: After some major testing with a few hundred mach-o binaries, the added instruction does not cause any problems so far.

rhelmot commented 6 years ago

Oh, sorry I forgot about this. Yes, we don't really like maintaining a fork of valgrind, but like, that's kind of what we have to be doing right now.