search

angr / vex

A patched version of VEX to work with PyVEX.
GNU General Public License v2.0
104 stars 44 forks source link

Fix CB{N}Z thumb instruction second attempt #15

Closed ArtemShypotilov closed 6 years ago

ArtemShypotilov commented 6 years ago

Added parameter to control branching at CB{N}Z instruction, moved default values definition for VexControl from pyvex.c:vex_init() to priv/main_main.c:LibVEX_default_VexControl

rhelmot commented 6 years ago

Looks good. One important thing though, is that nominally this is a soft fork of libvex, and we'd like to have our changes upstreamed at some point. that means that we want to keep the defaults the same as they normally are, including maintaining the default behavior of the new parameter implicitly being false.

I'm going to fix this and merge it. Thanks!