search

angr / vex

A patched version of VEX to work with PyVEX.
GNU General Public License v2.0
104 stars 44 forks source link

Add RISCV64 support #54

Closed alikates closed 1 year ago

alikates commented 1 year ago

I have rebased the code from https://github.com/petrpavlu/valgrind-riscv64 on top of angr version of libvex.

rhelmot commented 1 year ago

This is excellent! We'll gladly take this diff as soon as you can add the requisite pieces in pyvex and archinfo to support it.

alikates commented 1 year ago

I already opened PRs for both of them

https://github.com/angr/archinfo/pull/146 https://github.com/angr/pyvex/pull/310

rhelmot commented 1 year ago

They all look fine to me. Just make sure to switch the pyvex submodule back to pointing at the angr org. When you're ready for merge, please mark the PRs as ready for review.

rhelmot commented 1 year ago

Please fix the rebase and fix the pylint CI pass archinfo/pyvex and I'll hit merge.

rhelmot commented 1 year ago

Actually, what am I saying. There's no way your python diffs could be causing any real issues. Thank you for your contribution!

rhelmot commented 1 year ago

If you'd like to continue adding support to the angr suite for this, the next steps are a) add some regression tests to pyvex, b) add logic for calling conventions and syscalls numbers in angr, and c) add some regression tests to angr.

Xeonacid commented 1 year ago

I have rebased the code from https://github.com/petrpavlu/valgrind-riscv64 on top of angr version of libvex.

You should add petrpavlu (and contributors) as git commit author.

rhelmot commented 1 year ago

Done!