Closed EvelynVusky closed 11 months ago
I have absolutely no ability to review riscv-related code, so I will instead ask you this:
@rhelmot Yes, the VEX IR generator for the RISCV WFI instruction works in our tests and we believe it is ready to merge.
I'm only asking this because you added a commit to this branch related to CSR operations. Are those supposed to be merged now too?
@rhelmot No. We would like to submit the second commit related to CSR operations as a separate pull request, but we've got some more testing to do before submitting it.
Is it possible to merge just the initial commit ("VEX IR generator added for RISCV WFI instruction")? If not, we can back the second CSR commit out of the branch.
No, pull requests on github track branches, and I don't have the option to merge just some commits of a pull request. You'll need to either revert or reset that commit.
@rhelmot Understood, thank you. Just reverted the commit.
Thanks!
Added a VEX IR generator for the RISC-V WFI instruction in the dis_RV64Zicsr() function of guest_riscv64_toIR.c.