search

angristan / docker-pleroma

Docker image for the Pleroma federated social network
https://git.pleroma.social/pleroma/pleroma/
MIT License
348 stars 75 forks source link

Explain how to use the new dynamic config #50

Closed peterrus closed 2 years ago

peterrus commented 2 years ago

Explain how to use the new dynamic config introduced in #25 and remove references to the old style. I noticed the docs were not in sync with how the configuration system works now.

peterrus commented 2 years ago

@excodex @felix-two-tone This builds on your earlier work so feel free to let me know if you have any opinions on this.

felix-two-tone commented 2 years ago

So yea, this answers some questions that I had about what was going on with the two configs involved (Guess I should read more on this repo). So question, does this part of the process even need to occur anymore? I didn't really understand in the README.md that it was asking you to create this config file, it seemed to me that it never did anything.

Edit: wrong line

https://github.com/angristan/docker-pleroma/blob/09fa1e81e3a13c919732b2779e19e5cc7cae3d59/README.md?plain=1#L96

peterrus commented 2 years ago

@felix-two-tone nope, you don't need to create that config file anymore as it is included in the repo already and sources some values from the environment variables. If you want to configure things that are not configurable through environment variables you can use the config-override I added in this PR.

I have also removed the instructions to create that config/secret.exs file as it does indeed not get used and thus does nothing. Just use the config-override or hack the included dynamic config if you're so inclined (but I would not recommend that because your changes will conflict with any changes to that file being done upstream).

peterrus commented 2 years ago

@angristan should be ready to merge unless you have any questions or remarks.