search

angristan / nginx-autoinstall

Compile NGINX from source with custom modules and patches on Debian and Ubuntu
GNU General Public License v3.0
639 stars 237 forks source link

nginx-autoinstall.sh: Update Nginx mainline to v1.19.8 #179

Closed ghost closed 3 years ago

ghost commented 3 years ago

See https://nginx.org/en/CHANGES

angristan commented 3 years ago

Looks like Github actions is broken: https://www.githubstatus.com/incidents/s654n76c1bwr

I'll wait for the checks to pass before merging :)

angristan commented 3 years ago

Looks like the QUIC patch doesn't work anymore?

ghost commented 3 years ago

@angristan Indeed, it apparently needs to be updated for nginx v1.19.7+: https://github.com/cloudflare/quiche/issues/859

xopez commented 3 years ago

Since 1.19.10 is already out for mainline you should maybe change that version herer to. The problem with quiche is not fixed. Here is a little bit more info: cloudflare/quiche#936

jxlarrea commented 3 years ago

I don't really think they care enough to fix this.

ghost commented 3 years ago

I don't really think they care enough to fix this.

@jxlarrea The good news is that the Nginx devs started working on adding native HTTP/3 support to Nginx more than a year ago, so it's only a matter of time until the Quiche patch for Nginx becomes obsolete.

jxlarrea commented 3 years ago

I don't really think they care enough to fix this.

@jxlarrea The good news is that the Nginx devs started working on adding native HTTP/3 support to Nginx more than a year ago, so it's only a matter of time until the Quiche patch for Nginx becomes obsolete.

Do you know if anyone is using that branch in production? I wonder if it's actually usable.

ghost commented 3 years ago

Do you know if anyone is using that branch in production? I wonder if it's actually usable.

No idea. The announcement from a year ago says that it shouldn't be used in production since the HTTP/3 standard hasn't been finalized yet, which is still the case today. I wouldn't expect it to be ready for production until after the IETF publishes HTTP/3 as an RFC and HTTP/3 support lands in OpenSSL.

xopez commented 3 years ago

A short overview of supported browsers: https://caniuse.com/http3

angristan commented 3 years ago

In https://github.com/angristan/nginx-autoinstall/pull/191, I disabled the patch in the CI and added some warnings. Hopefully there will be way to have HTTP/3 on recent versions soon, either from Cloudflare or Nginx. 🙂

MaximeMichaud commented 3 years ago

In #191, I disabled the patch in the CI and added some warnings. Hopefully there will be way to have HTTP/3 on recent versions soon, either from Cloudflare or Nginx. 🙂

They are working on it (NGINX), but right now this is fucktop. Cloudflare should have fix the patch and NGINX release HTTP3. Same for OPENSSL.