angristan / nginx-autoinstall

Compile NGINX from source with custom modules and patches on Debian and Ubuntu
GNU General Public License v3.0
636 stars 237 forks source link

Fix quiche path #221

Closed karelbasta closed 2 years ago

karelbasta commented 2 years ago

Since the quiche repository refactor in commit #bbe6e2a path for boringssl needs an update. I tested this on my machine with success.

karelbasta commented 2 years ago

I am not much confident in making github actions, but do you think you could make one for BoringSSL?

karelbasta commented 2 years ago

While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well.

angristan commented 2 years ago

Does this PR remove the need for https://github.com/angristan/nginx-autoinstall/pull/220 ?

angristan commented 2 years ago

While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well.

You can enable it in this PR if you want, we could make sure that everything is fixed

karelbasta commented 2 years ago

Does this PR remove the need for https://github.com/angristan/nginx-autoinstall/pull/220 ?

Yes it does

karelbasta commented 2 years ago

While at it, there is a permanently disabled HTTP3 entry for an headless FULL installation in wrapper.sh which could get enabled as well.

You can enable it in this PR if you want, we could make sure that everything is fixed

On it

karelbasta commented 2 years ago

Okay, so there is an error in checks which I do not get on my physical machine. ./configure: error: invalid option "--with-quiche=/usr/local/src/nginx/modules/quiche" Which did not get changed in any of the commits.

karelbasta commented 2 years ago

Now I am even more confused as these checks were successful in my fork.

karelbasta commented 2 years ago

I forgot to edit the nginx-1.16 patch path in the PR. The path is now fixed and checks are fixed as well.

karelbasta commented 2 years ago

Glad to help.