ns3 namespace replace - Githubissues

angro-kft / nav-connector

Node.js module which provides an interface for communicating with NAV online invoice service.

GNU General Public License v3.0

35 stars 11 forks source link

ns3 namespace replace #77

Closed peter-gyulavari closed 3 years ago

pzs commented 3 years ago

Hi, just a comment: it's may not safe to remove namespaces in this way:

you replace ns2/3: in the whole data, not just in the name of the element (-> <val>some value with ns2: text in it</val>)
you replace only ns2/3 namespaces, however it could be any text defined at the top of the XML, it's not guaranteed it will be ns2/3 always.

A bit better solution would be this regexp (maybe based on this answer), however manipulating XML as a string is not the best in general.