Actually disable assertions in release mode. Whoops!

angry-goose-initiative / wiki

AGI Wiki

0 stars 0 forks source link

Actually disable assertions in release mode. Whoops! #41

Open JZJisawesome opened 7 months ago

JZJisawesome commented 7 months ago

Turns out we never defined NDEBUG on the command line during release builds. I figured CMake/gcc would do this automatically, turn out that's not the case.

Disabling assertions as it turns out breaks a bunch of code since our errors are super aggressive about unused variables. This will take some time to fix.

Work is ongoing on the personal/jzj/ndebug branch

JZJisawesome commented 7 months ago

I have fixed this in IRVE. However DNDEBUG is still not set in RVSW due to linking issues. But we're getting there!