search

angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

Ignore smart quotes #1

Closed NilsFagerburg closed 5 years ago

NilsFagerburg commented 5 years ago

The OS wide "smart quote" setting interferes with some games (apostrophes in particular but I guess it could happen with other substitutions too). I think Spatterlight should probably ignore the setting and never substitute characters.

Here's a patch that seems to work with the caveat that I don't know that language so it's in all likelihood not a clean / idiomatic way of doing things.

brol.patch.txt

angstsmurf commented 5 years ago

Thanks a lot!

I wonder if it might actually be better to convert any curly quotes "behind the scenes" before the input gets sent to the interpreter, but your way is simpler.

angstsmurf commented 5 years ago

I pushed a slightly modified version of this as f529085 .

angstsmurf commented 5 years ago

By the way, do you have a good test case for this? Otherwise I guess I could write one myself.

angstsmurf commented 5 years ago

This should fixed by the changes in the new release. Let me know if it isn't. Thanks again!