search

angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

[Bocfel] Fix exception handling #23

Closed cspiegel closed 3 years ago

cspiegel commented 3 years ago

I made a boneheaded mistake which made its way into Bocfel 1.2 (and 1.2.1). In short, if there is an error writing a save file, there'll be undefined behavior. It's not critical, though, since there should only be a write error if there's an issue like a full disk or I/O error.

I think you're probably the only active user of Bocfel outside of Gargoyle, and since you're doing regular releases, I'm providing a fix here until the next Bocfel release. Again, this isn't something that anybody is likely to run into, but still better to have it fixed.

angstsmurf commented 3 years ago

Thanks a lot! If I'm not mistaken, this is the first external pull request for this project.