search

angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

Expose garglk text formatting functions #3

Closed curiousdannii closed 4 years ago

curiousdannii commented 5 years ago

You should expose the garglk text formatting functions.

https://curiousdannii.github.io/if/gargoyle.html

The same changes for Garglk https://github.com/garglk/garglk/commit/8f7083660100057f755a70034d429feba6f74345 https://github.com/garglk/garglk/commit/d057f8018cc0be1f9f274f10fb7c0872169c8a96

curiousdannii commented 5 years ago

Actually, despite the functions being in Spatterlight's glk.h, they aren't actually defined. I thought this would be a freebie. Does Spatterlight support colour in Z-Machine or not?

It might take more work to expose. But it might be possible? I see code using insertionPointColor that looks promising.

angstsmurf commented 5 years ago

Thanks for taking a look! Any feedback at all on this code is encouraging.

No, currently Spatterlight does not support Z-Machine colours, or any of Gargoyle's extensions to Glk. I don't know why those functions are in glk.h, but I've probably been careless when copying stuff from Gargoyle.

It has been on my todo-list from the start, though, so I'll definitely look into it.

angstsmurf commented 4 years ago

These are implemented now.

curiousdannii commented 4 years ago

Wow, that's fantastic! Thank you!