search

angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

Xcode maintenance: #36

Closed MaddTheSane closed 2 years ago

MaddTheSane commented 2 years ago

Remove old Xcode-generated files. Remove the need for a prefix header. Embed the App Extensions.

angstsmurf commented 2 years ago

Thanks a lot for this!

Just to make sure that we are on the same page: The original idea was that the master branch should be ”outside contributor friendly” and buildable by anyone out of the box, without needing to change any settings or even an Apple developer account, as per the build instructions in the README.md. This means that the QuickLook plugins, which require an App Group in order to read be able to read the common Core Data Store, are disabled in the master branch.

To actually build the notarized application with functioning plugins, I instead use the release branch, where automatic signing is turned on for every binary and the team is set to me.

I don't know if this is worth the trouble and the potential confusion. It certainly has not attracted a lot of outside contributors. Perhaps it is time to give it up. But as things stand, this PR is not compatible with this setup, as far as I can tell.

angstsmurf commented 2 years ago

Right, I merged this manually now, along with some git acrobatics to keep the master branch buildable out of the box (I hope). Thanks again! That was a lot of cruft.

MaddTheSane commented 2 years ago

I was wondering why the QuickLook plugins weren't included…