search

angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

Remove unnecessary null pointer checks #64

Closed elfring closed 1 year ago

elfring commented 1 year ago

Extra null pointer checks are not needed in functions like the following.

angstsmurf commented 1 year ago

Thanks! I'll look into it. I really should try to learn C++ properly one of these days.

As these are all in the Tads 3 source, the people over at the main Tads repo might appreciate this as well.

elfring commented 1 year ago

As these are all in the Tads 3 source, …

Is the “Text Adventure Development System” still maintained?

angstsmurf commented 1 year ago

The repo over at https://github.com/tads-intfic/tads-runner is an attempt to maintain it. There hasn't always been a huge amount of activity there, but there was an update two weeks ago. I'm sure they will be glad for any contributions.

elfring commented 1 year ago

:thought_balloon: Can similar update candidates be found also for other software components?

angstsmurf commented 1 year ago

Look, don't take this the wrong way, but I'm not a 100 percent sure I'm talking to a human being here.

elfring commented 1 year ago

:crystal_ball: It seems to become more popular to present an assumption according to “ChatGPT”.

:thought_balloon: Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?