search

angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

Corners in new windows have an unsightly white region until resized #7

Closed agustincordes closed 3 years ago

agustincordes commented 4 years ago

All new windows (including the library) have this issue until they're resized in some way.

Screen Shot 2020-04-22 at 11 41 55
angstsmurf commented 4 years ago

I had those too for a while, but now I can't reproduce it any more. What OS are you on?

ghost commented 4 years ago

Probably related to https://github.com/electron/electron/issues/517 with a fix.

angstsmurf commented 4 years ago

Thanks! It is still not clear to me what causes the problem or how to test it, but I guess I could set all windows to be non-opaque, even if it is supposed to be bad for performance.

It would be cool to have actual transparent windows like in Terminal or Zoom, though.

ghost commented 4 years ago

Forgot to add that I think this only happens in the latest macOS versions. I'm on OS X 10.11 (El Capitan) and I don't suffer from this issue.

angstsmurf commented 4 years ago

I've tried to reproduce it on 10.7, 10.8, 10.9, 10.14 and 10.15 without success, so I guess it only occurs under very specific conditions.

agustincordes commented 4 years ago

I'm running Catalina 10.15.4. I'll be glad to help testing.

angstsmurf commented 4 years ago

It seems I have no good solution for temporary file upload, so I'm abusing the Github release function. Perhaps you could try out these three builds and see if the problem is still there?

agustincordes commented 4 years ago

Spatterlight_upgraded_nibs and Spatterlight_not_opaque throw an "Application is damaged" error, probably because they aren't notarized. But I'm happy to report that Spatterlight_notarized_10.15_only works well. There's even another UI error that I didn't report that got fixed in this build.

This happens in 0.5.12b when the menu bar is shown while in fullscreen:

Screen Shot 2020-04-22 at 17 28 13

And it's now fixed in the 10.15 build:

Screen Shot 2020-04-22 at 17 27 52
angstsmurf commented 4 years ago

Thanks for trying them out! Well, at least we know that targeting the 10.15 SDK fixes this particular problem. I'll do the lazy thing and just add that version to the other two for now.

agustincordes commented 4 years ago

No complains 😄

I'll try to contribute with some tweaks as soon as I can!

angstsmurf commented 4 years ago

That would be great!

By the way, the reason I didn't see these glitches on Catalina was probably that I run it in a VM, without hardware graphics acceleration. Perhaps I should just bite the bullet and upgrade to Catalina.

agustincordes commented 4 years ago

It works pretty well, I'd say it's a mandatory upgrade at this point!

ghost commented 4 years ago

I'd say it's a mandatory upgrade at this point!

Unless you're on old hardware and can't update anymore past 10.11. :/

angstsmurf commented 3 years ago

Update: I've upgraded to Catalina 10.15.7 and I can't reproduce this problem, which hopefully means it is fixed now.