angstsmurf / spatterlight

Updated fork of Spatterlight
GNU General Public License v3.0
105 stars 5 forks source link

Support Dark Mode? #72

Closed johncoxon closed 1 year ago

johncoxon commented 1 year ago

It would be very nice to be able to select a theme to use in Dark Mode and a theme to use in Light Mode.

angstsmurf commented 1 year ago

That would be very nice! The hard part is really to come up with a simple, intuitive, non-confusing UI for it. I have some ideas.

angstsmurf commented 1 year ago

Here is a very experimental version. It would be great if you could give it a whirl and let me know what you think.

There are two ways to designate themes for light or dark mode: checkboxes in the Details tab of the preferences window, and new menu items in the Themes tab menu (Use for Light Mode and Use for Dark Mode).

I am particularly curious about how it works with game-specific themes, i.e. when the "Changes apply to all games in library" checkbox on the Themes tab is off. This was always kind of confusing and most likely not used by anyone. Does it work as you would expect when you switch off "Use for X Mode" and it goes back to the old behaviour?

Spatterlight.zip

Nephar commented 1 year ago

Seems to work OK in Mojave.

When Changes apply to all games in library is on, all games switch to whatever I have chosen for Use for X Mode. And if the system is in dark mode and I have a dark mode theme set, then I cannot apply a different theme from the game menu(grayed), which is as it should be.

When Changes apply to all games in library is off, Use for X Mode forces all games to use same theme in that mode, but if no theme is set for the other mode, all games switch back to their own preferred theme when I switch to that mode.

In summary, I found no inconsistencies in the behaviour.

angstsmurf commented 1 year ago

Thanks! That is good to hear.

Let me know if any bugs turn up or if there is anything that should be improved.

johncoxon commented 1 year ago

This is perfect; I couldn't find anything wrong but I only have one .z5 file to test with. I'll post here if I do come across any inconsistencies. Thank you so much.

angstsmurf commented 1 year ago

This is now included in release 1.1.