angturil / SongRequestManager

Song Request Manager is an integrated, fully Customizable song request bot and Console for BeatSaber.
GNU Lesser General Public License v3.0
42 stars 33 forks source link

[Feature Request] Option to only allow requesting local songs #35

Open Phoenix616 opened 4 years ago

Phoenix616 commented 4 years ago

It would be cool if there was a way to only allow requesting of local songs (and maybe make searching online a mod/sub feature). I guess this might also need a command to list possible local ones.

angturil commented 4 years ago

I think that.. could be possible. It would involve a prescan , and marking the song database with a "local" flag. I'll add it to my "todo" list.

angturil commented 4 years ago

srm already does searches locally.

Phoenix616 commented 4 years ago

Oh, just found that there apparently is an "OfflineMode" config setting which does that together with the local options? Might be good to add to the readme :)

I guess this ticket could be about subs/mods bypassing that then.

angturil commented 4 years ago

the offline mode stuff is partially broken - offline searches work, but not downloads/plays. It used to work :) So yeah, once that's fixed, it will work

YoukaiTheGit commented 3 years ago

Can you clarify what "local search" vs. "offline mode" mean? Whenever beatsaver APIs are down, any request attempt simply results in "invalid id" errors, even if the song is already available locally. So if the purpose of local search is to allow requesting of local songs, it seems there is still a dependency on web services.

angturil commented 3 years ago

Working on scanning the local directory now - coming soon (tm)

angturil commented 3 years ago

offline mode lets you use a songdatabase file to bypass beatsaver.com for searches (but not downloads) getting the file is tricky however ... and can't be done right now cause beatsaver is down.

YoukaiTheGit commented 3 years ago

OK, that makes sense, thanks. I wouldn't expect downloads to work. but a degraded mode for putting a local song into the queue without some of the real-time metadata (ratings, the code->song mapping) would often be preferable to no requests at all.