search

angular-architects / module-federation-plugin

MIT License
698 stars 190 forks source link

Please include license in @angular-architects/module-federation #157

Open Seledrex opened 2 years ago

Seledrex commented 2 years ago

It would be great if the LICENSE file for @angular-architects/module-federation was included in the package on npm. It makes linking back to the license for the specific version of the package much easier 🙏

waynebloss commented 5 months ago

Also missing from @softarc/native-federation

https://github.com/module-federation/vite/issues/22

cgrabmann commented 2 months ago

There was a pull request opened for this already more the 1 year ago, but after 2 rebases the author of the PR just closed it, since it was never accepted :( https://github.com/angular-architects/module-federation-plugin/pull/298

Would really be nice to have the license and the link to the repo in all published packages. It would also resolve issues with automatic license checking tools.

@manfredsteyer it took me like 1 hour to figure out that all packages are actually within this repo, since the npm scope of the generic JS packages (@softart) did not suggest they live here.

Should I create another PR that resolves this?