angular-architects / module-federation-plugin

MIT License
683 stars 184 forks source link

Import compensation for React #529

Open sedx opened 1 month ago

sedx commented 1 month ago

We are used Native Federation with Vite and esbuild adapter.

Adapter is not call compensateExports for named imports.

Instead used named imports:

import { lazy }  from 'react';
const Lazy = lazy(() => /** */);

We should use default:

import React from 'react';
const Lazy = React.lazy(() => /** */);

It's not comfortable because:

I uncomment call of compensateExports https://github.com/angular-architects/module-federation-plugin/pull/501 and now it works fine.

FIY: @jogelin - you add todo with question about should we delete unused compensateExports, looks like it's usable feature. @manfredsteyer - you comment call of compensateExports, maybe you have some reason for do it