search

angular-architects / module-federation-plugin

MIT License
735 stars 203 forks source link

fix(nf): correct the index file path for SSR builds in the updateIndexHtml util #677

Open vrady opened 1 month ago

vrady commented 1 month ago

Angular CLI generates an index.csr.html file for SSR builds, causing the updateIndexHtml function to fail since it looks for an ‘index.html’ file. To ensure the function works correctly, a check for the SSR option needs to be added to the utility.

vrady commented 1 month ago

@rainerhahnekamp @manfredsteyer hi, I attempted to manage the CI, but it failed. The branch is forked from angular-architects:main, so there shouldn’t be any issues with hash checking.

rainerhahnekamp commented 1 month ago

@vrady just to be sure. You are having issues with our CI, right?

vrady commented 1 month ago

@rainerhahnekamp yes, npx nx format:check fails https://github.com/angular-architects/module-federation-plugin/actions/runs/11427097483/job/31790830897?pr=677 image