search

angular-architects / ngrx-toolkit

Various Extensions for the NgRx Signal Store
MIT License
98 stars 16 forks source link

misc: refactored named types of withCallState #23

Closed flensrocker closed 3 months ago

flensrocker commented 4 months ago

This is a suggestion for an easier mapping of the state and signal types to the named (collection) types.

If you're ok with this I can take a look at the other mappings.

I've also reordered them so that the dependent type comes first.

rainerhahnekamp commented 4 months ago

Hi Lars, thanks for the PR. We are more than just OK, if you find look for improvements.

flensrocker commented 4 months ago

I took a look at the other extensions and their name mappings are not so straight forward like the one in withCallState. So for now this is all I have to contribute. But since I just started writing my own extensions to the signal-store, I maybe come back later with more PRs.

rainerhahnekamp commented 3 months ago

Thanks Lars!