[Suggestion] CallState: rename loaded to success

angular-architects / ngrx-toolkit

Various Extensions for the NgRx Signal Store

MIT License

98 stars 16 forks source link

[Suggestion] CallState: rename loaded to success #25

Open the-ult opened 3 months ago

the-ult commented 3 months ago

Could it be an idea to rename loaded to success or something like that? Since the state of the response is successful. Otherwise it would be error. Correct?

If @rainerhahnekamp agrees, I could provide a PR with the proposed change

See: https://github.com/angular-architects/ngrx-toolkit/pull/23#discussion_r1523254356

rainerhahnekamp commented 3 months ago

I'll have to bring @manfredsteyer in. He has ownership of the callstate extension.