serializing bigint - Githubissues

angular-architects / ngrx-toolkit

Various Extensions for the NgRx Signal Store

MIT License

98 stars 16 forks source link

serializing bigint #31

Open robmanganelly opened 3 months ago

robmanganelly commented 3 months ago

Content of this PR:

2 Functions that wrap JSON.stringify and JSON.parse to include serialization and rehydration of bigint values.
Unit test code modifications to include values of type bigint on test cases.

Considerations.

I applied the functions in place for the sake of brevity, but next iterations could move them into utility space and get them their own unit test.
There is a commented test case, see line 137 that has failing test case, which i did not fix, as it is a different issue, unrelated to this PR.

robmanganelly commented 2 months ago

Sorry for the late reply. Yes. I will take care of it. Thanks for the comments.

rainerhahnekamp commented 2 months ago

@robmanganelly if you don't have the time, no worries. We'll merge and I can do the changes myself. Just let me know, cheers!

robmanganelly commented 2 months ago

Honestly, I don't want to pass the workload onto you guys. I'm really happy to contribute to this project, even if my contributions are minuscule, but I currently don't have the bandwidth, sadly, for which I apologize. I can reach out once I'm done with my current tasks, and if changes are still needed, I'll be more than happy to handle them myself.

Otherwise, please proceed as you see fit.