Open michael-small opened 3 months ago
Good idea @michael-small, I'll wait for the removal of the draft status.
@rainerhahnekamp
I am marking this as ready since it is basically done and covers most scenarios.
new Store()
and mock implementing it throwing an error, or making a new StoreWithErrors
that throw errors in the implementations, and other variations to no success. I am curious what you would suggest, or if you could please show me an example of how you might write one.Perhaps this is too undercooked a submission as well but I think I may have overthought/overdone certain aspects and would appreciate feedback before going further in a fruitless direction.
Good work so far. I'd suggest that in the first round of review, we focus on slimming down the amount of code. Depending on where we end up, we could then maybe split the file into multiple files or everything is alright.
Sounds good, thanks. I'll slim it down with your suggestions and a couple things that have occurred to me since and then @ you when it's at that point.
Prerequisite to feat: add support for observables to withDataService
I said that I would make tests for
withDataService
featuring support for observables. However, it would be good to have existing tests for the feature as it is currently with promises before thewithDataService
is further extended.Once I have a test for each method of the
interface DataService
with promises stubbed out then I'll bump this from a draft to a full PR. Tests are not my strong suit, so please roast these.edit: Progress/TODO 9/29/2024