search

angular-architects / nx-ddd-plugin

Nx plugin for structuring a monorepo with domains and layers
313 stars 56 forks source link

[Question] Why is generating an app for ngrx flag mandatory #32

Closed CodewindOnGithub closed 2 years ago

CodewindOnGithub commented 3 years ago

I don't understand why we are forced to generate an app when we just want to generate a domain using ngrx flag. Could the plugin not just skip adding the root store part in an app.

Also the current documentation is unclear because these commands:

ng g @angular-architects/ddd:domain booking --addApp --ngrx
ng g @angular-architects/ddd:feature search --domain booking --entity flight --ngrx
[...]

Do not result in the dependency graph as shown.

My current workaround is to generate a domain and clean up afterwards, could this be changed in the future?

pascalbe-dev commented 3 years ago

I agree. Not everyone has an app for each domain. It's probably often the case, that you want one app which pulls in features from different domains.

@manfredsteyer @peterbsmith2 what do you think?

manfredsteyer commented 3 years ago

Good point. Honestly, I don't remember the reason. @peterbsmyth - Do you remember it?

manfredsteyer commented 2 years ago

In version 2.0.0 this will be optional