search

angular-architects / nx-ddd-plugin

Nx plugin for structuring a monorepo with domains and layers
313 stars 56 forks source link

Have questions about libNameAndDirectory? #79

Closed zhangjindong closed 3 years ago

zhangjindong commented 3 years ago

https://github.com/angular-architects/nx-ddd-plugin/blob/f9414527aa5372c1058af79d13bf3ea8e4f746fa/libs/ddd/src/schematics/domain/index.ts#L36

Why is ${libName}/${options.directory} Instead of ${options.directory}/${libName} I think Domain is unique, which means that Domain/Directory can only have one directory.

We might need something like this: libs/management/user/domain libs/management/user/feature- libs/management/dept/domain libs/management/dept/featue-

Did I understand it wrong?

cogoo commented 3 years ago

I think this is a bug, I've resorted to switching the names around to get my desired output

sg-gdarnell commented 3 years ago

I think you're correct. This command:

ng g @angular-architects/ddd:domain user --directory=management

Generates libs/user/management/domain instead of libs/management/user/domain

I think this is incorrect, given that it's inconsistent with directory in vanilla nx generators and with appDirectory in the same command just a few lines above in the same file:

https://github.com/angular-architects/nx-ddd-plugin/blob/f9414527aa5372c1058af79d13bf3ea8e4f746fa/libs/ddd/src/schematics/domain/index.ts#L24