Closed meeroslav closed 3 years ago
We don't currently adding a matcher
as part of the route component, but if we did, would the custom matcher also have to return the matchRoute
signature?
Any custom regex matcher will return RouteMatch | undefined
when used in the matchRoute
function.
It's just mapping the param names taken from the URL definition onto the result of the regex match.
The only "problem" I've seen while testing custom matchers was when the URL did not specify params (e.g. /:something) but regex did. In this case, param names could not be parsed. But the same issue exists with path-to-regex
.
This is solvable, of course, but i's a corner case that might never be hit.
Hi, is there anything left to be added to this PR?
state$
observable to reduce the overflow of events caused by https://github.com/brandonroberts/angular-routing/commit/d4bc65d195fdb16f5189a0687c5f5224a76e4abc