angular-component / router

Angular Component Router - A declarative router for Angular applications
MIT License
253 stars 16 forks source link

fix: apply nullable checks for async inputs #74

Closed kylecannon closed 3 years ago

kylecannon commented 3 years ago

async pipe typically emits a null before the value which causes everything to blow up. To correct this, I did the following:

There may be other instances I am missing, but this is a start.

kylecannon commented 3 years ago

Thanks for the feedback @brandonroberts. Feedback is addressed.

brandonroberts commented 3 years ago

@kylecannon will you rebase on master? Had to move some things around with the name change

kylecannon commented 3 years ago

@brandonroberts done. Still trying to see what needs to be done though to get this merged. I commented above with a couple of suggestions.