search

angular-component / router

Angular Component Router - A declarative router for Angular applications
MIT License
253 stars 16 forks source link

Upgrade to Nx 11 and Angular 11 #77

Closed kylecannon closed 3 years ago

kylecannon commented 3 years ago

Closes #61

brandonroberts commented 3 years ago

Not sure we're ready to upgrade yet. We currently support Angular 9+, but if we upgrade the packages along with the compiler, I'd consider it to be a breaking change.

kylecannon commented 3 years ago

Working on fixing the tests now. As for the upgrade, I was doing one of the issues that are open (https://github.com/brandonroberts/angular-routing/issues/61). Do you not want this done right now?

From my understanding, upgrading the packages themselves to angular 11 shouldn't be an issue cause everything is still compiled down to ViewEngine and then is ran through ngcc to ivy.

Let me know.

brandonroberts commented 3 years ago

@kylecannon yea let's upgrade and we'll see how it goes. You'll have to rebase with the name change

kylecannon commented 3 years ago

Alright, I rebased and also had to update the schematics as well due to https://github.com/angular/angular-cli/commit/6631720ec3ff4e2f15b781d9516d88314e1a5197.

brandonroberts commented 3 years ago

Something went wrong as it deleted a bunch of files?

kylecannon commented 3 years ago

huh ok this is weird. let me see..

kylecannon commented 3 years ago

Ya, don't know what happened there. I force-pushed to bring everything back.

Sorry about that 🙃

kylecannon commented 3 years ago

Ok, will do that. I guess using the create nx workspace added this cause I don't use vscode 🤷🏻‍♂️

On Sat, Feb 6, 2021 at 12:17 PM Miroslav Jonaš notifications@github.com wrote:

@meeroslav commented on this pull request.

In .vscode/extensions.json https://github.com/angular-component/router/pull/77#discussion_r571483704 :

@@ -0,0 +1,9 @@ +{

VSCode extensions should not be part of the project. Please remove this file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular-component/router/pull/77#pullrequestreview-584915515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGT5CT73F2ZZWVUZDFHP5LS5WPWBANCNFSM4VNYAHXQ .

-- Thanks, Kyle Cannon

The contents of this email are intended for the named addressee only, and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you received it in error please notify us immediately and then destroy it.

kylecannon commented 3 years ago

@brandonroberts any chance we can get this merged?