search

angular-extensions / elements

Lazy load Angular Elements (or any other web components / custom elements ) with ease!
https://angular-extensions.github.io/elements/
MIT License
315 stars 40 forks source link

Fix issue with the isModule property being ignored. #124

Closed apokralipsa closed 1 year ago

apokralipsa commented 2 years ago

Fixes #123

There might be more similar cases introduced when the strict mode was being enabled in tsconfig.json. I am not aware of them as I am mostly configuring elements using ElementConfigs.

tomastrajan commented 1 year ago

hey there @apokralipsa !

Thank you very much for your effort, I have missed it before the A14 update so now there is a conflict, would be really interested in adding this.

Could you please update the PR ?

Thank you!

apokralipsa commented 1 year ago

Hey @tomastrajan Rebased and fixed the conflicts. Locally I have some issue with running npm run test now. It says I am missing some files matching /projects/**/*.md. Do I need to update some markdown manually?

codecov-commenter commented 1 year ago

Codecov Report

Merging #124 (943b812) into master (d9a4e49) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   87.47%   87.45%   -0.03%     
==========================================
  Files          53       53              
  Lines         575      574       -1     
  Branches       71       71              
==========================================
- Hits          503      502       -1     
  Misses         72       72
Impacted Files Coverage Δ
...zy-elements/lazy-element/lazy-element.directive.ts 85.50% <ø> (-0.21%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.